New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows to make Istio and VirtualServices optional #2380
Allows to make Istio and VirtualServices optional #2380
Conversation
b1b4330
to
247de7f
Compare
pkg/controller/v1beta1/inferenceservice/reconcilers/ingress/ingress_reconciler.go
Outdated
Show resolved
Hide resolved
pkg/controller/v1beta1/inferenceservice/reconcilers/ingress/ingress_reconciler.go
Outdated
Show resolved
Hide resolved
b7c0fbc
to
bc21ef6
Compare
6c4fc81
to
a8e0915
Compare
/retest |
a8e0915
to
e67d4a3
Compare
c3e6bca
to
ebc183b
Compare
pkg/controller/v1beta1/inferenceservice/reconcilers/ingress/ingress_reconciler.go
Outdated
Show resolved
Hide resolved
c0d3847
to
b1b7465
Compare
pkg/controller/v1beta1/inferenceservice/reconcilers/ingress/ingress_reconciler.go
Outdated
Show resolved
Hide resolved
pkg/controller/v1beta1/inferenceservice/reconcilers/ingress/ingress_reconciler.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
b1b7465
to
ce0ee11
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Suresh-Nakkeran, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com> Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com> Signed-off-by: alexagriffith <agriffith96@gmail.com>
@Suresh-Nakkeran : 1qq, say we go with disabling the top level virtual service and now deploy an ISVC with both transformer and a predictor.
Is it possible to add a diagram of what was there earlier with Top Level VS and what can now be achieved with disabling top level VS ? |
Signed-off-by: Suresh-Nakkeran suresh.n@ideas2it.com
What this PR does / why we need it:
This PR allows followining:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1336
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
DisableIstioVirtualHost
is true, KServe does not create the top level virtual service thus Istio is no longer required for serverless mode.DisableIstioVirtualHost
is true, KServe works with Contour.DisableIstioVirtualHost
is false, KServe works like before.Special notes for your reviewer:
Checklist:
Release note: