Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce numpy version constraints #2424

Merged
merged 1 commit into from
Sep 17, 2022
Merged

Conversation

alembiewski
Copy link
Contributor

@alembiewski alembiewski commented Sep 16, 2022

What this PR does / why we need it:
Ease upper-bound version constraints for numpy package for better compatibility with other open-source libraries.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
fixes #2075
In the context of Predict on an InferenceService with transformer using Feast online feature store, I'm trying to install the latest version of the Feast Python SDK (pip install feast) together with the latest kserve package and I'm getting the following error from pip:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
kserve 0.9.0 requires numpy~=1.21.5, but you have numpy 1.23.3 which is incompatible.

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing:

Special notes for your reviewer:

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:


Signed-off-by: Alex Lembiyeuski <alembiyeuski@d2iq.com>
@yuzisun
Copy link
Member

yuzisun commented Sep 17, 2022

Thanks @alembiewski !
/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alembiewski, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kserve-oss-bot kserve-oss-bot merged commit 1fdf6c4 into kserve:master Sep 17, 2022
alexagriffith pushed a commit to alexagriffith/kserve that referenced this pull request Sep 23, 2022
Signed-off-by: Alex Lembiyeuski <alembiyeuski@d2iq.com>

Signed-off-by: Alex Lembiyeuski <alembiyeuski@d2iq.com>
Signed-off-by: alexagriffith <agriffith96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we loose the requirement on numpy library
3 participants