Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CIFAR-10 Outlier Detector sample #2472

Merged
merged 1 commit into from
Oct 15, 2022
Merged

Update CIFAR-10 Outlier Detector sample #2472

merged 1 commit into from
Oct 15, 2022

Conversation

rafvasq
Copy link
Member

@rafvasq rafvasq commented Oct 13, 2022

What this PR does / why we need it:
This PR fixes and updates the CIFAR-10 Outlier Detection sample and related notebook which were pointing to a model that no longer existed. It also copy-edits the notebook for consistent and accurate steps.

Resolves #2222

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Tested by running the notebook sample itself to working order.

Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
@rafvasq rafvasq changed the title update cifar-outlier-detector sample Update CIFAR-10 Outlier Detector sample Oct 13, 2022
@yuzisun
Copy link
Member

yuzisun commented Oct 13, 2022

Hi @rafvasq, thanks for the update! We also have the same website example here, should we keep one place instead of two copies?

@yuzisun
Copy link
Member

yuzisun commented Oct 15, 2022

Thanks @rafvasq !!

/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rafvasq, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outlier detect sample model does not exist any more
3 participants