Update quick install script to add Cluster Autoscaler and istiod memory leakage fix fields #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Swapnesh Khare <swapkh91@gmail.com>
|
thanks @swapkh91 ! /lgtm |
|
thanks @swapkh91 ! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: swapkh91, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sriumcp
pushed a commit
to sriumcp/kserve
that referenced
this pull request
Mar 7, 2023
Signed-off-by: Swapnesh Khare <swapkh91@gmail.com> Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Iamlovingit
pushed a commit
to Iamlovingit/kserve
that referenced
this pull request
Oct 1, 2023
Signed-off-by: Swapnesh Khare <swapkh91@gmail.com> Signed-off-by: iamlovingit <freecode666@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Swapnesh Khare swapkh91@gmail.com
What this PR does / why we need it:
Kubernetes Cluster Autoscaler (tested on GKE) expects pods to have
cluster-autoscaler.kubernetes.io/safe-to-evict: "true"annotation to mark them safe for eviction from a node and scale down the node (ref). Istio specific pods do not have these annotations and hence are not scaled down if created on a new node during autoscaling.As of Istio version 1.15, the
istiodcomponent suffers from memory leakage (ref), which is fixed in 1.16 (ref) by disablingPILOT_ENABLE_CONFIG_DISTRIBUTION_TRACKINGenvironment variable.istiodnow takes 0.5M CPU and 2GB memory by default. These can be changed by setting fields ink8skey.Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Ran
quick_install.shwith the updated script on cluster with Kubernetes version 1.22 (1.22.16-gke.1300)Checked
istiodandistio-ingressgatewaypods to contain safe-to-evict annotationCluster Autoscaler successfully downscaled a new node
Logs
Annotation set
CPU and memory leakage before setting
PILOT_ENABLE_CONFIG_DISTRIBUTION_TRACKINGflagfalseRelease note: