Fix KUBE_VERSION variable in quick_install.sh file
#2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nagar-ajay can you help sign off the commit ? |
kserve#2661 issue Signed-off-by: nagar-ajay <ajay.nagar@nutanix.com>
nagar-ajay
force-pushed
the
bug-fix/quick_install
branch
from
d4d2b96
to
aba72dd
Compare
@yuzisun Done |
|
Thanks @nagar-ajay ! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nagar-ajay, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sriumcp
pushed a commit
to sriumcp/kserve
that referenced
this pull request
Mar 7, 2023
kserve#2661 issue (kserve#2662) Signed-off-by: nagar-ajay <ajay.nagar@nutanix.com> Signed-off-by: nagar-ajay <ajay.nagar@nutanix.com> Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
KUBE_VERSIONvariable in quick_install.sh file by grepping the server version line, instead of relying on line numbers.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
KUBE_VERSIONvariable on my machine with Kubernetes Server Version: v1.25.3 and Kubernetes Server Version: v1.22Special notes for your reviewer:
--shorthas been deprecated and will be removed in the future. The --short output will become the default. Contributors will need to update this again when the --short flag is completely deprecated in next releases. Contributors will also need to consider the fact if kubernetes keeps the output backward compatible or not.Checklist:
Release note: