Add check for adding gpu tag suffix when image field is specified #2709
Conversation
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
| container.Image = image + "-gpu" | ||
| //check for the case when image field is specified directly with gpu tag | ||
| if !strings.HasSuffix(container.Image, "-gpu") { | ||
| container.Image = image + "-gpu" |
There was a problem hiding this comment.
Why do we need to add -gpu tag and not just directly pick the image field as it is ?
Like this:
container.Image = image
There was a problem hiding this comment.
The torchserve cpu and gpu image has different tags, on the serving runtime it defines the cpu image tag so we need to append the gpu suffix based on the resource requirement user defined on inference service yaml.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Suresh-Nakkeran, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
…erve#2709) Signed-off-by: Dan Sun <dsun20@bloomberg.net>
…erve#2709) Signed-off-by: Dan Sun <dsun20@bloomberg.net> Signed-off-by: Srinivasan Parthasarathy <spartha@us.ibm.com>
…erve#2709) Signed-off-by: Dan Sun <dsun20@bloomberg.net> Signed-off-by: iamlovingit <freecode666@gmail.com>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2708
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note: