Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the Go version for the builder image #2860

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Apr 27, 2023

What this PR does / why we need it:

fixes #2862

Go builder images use go version 1.18.10 which has several vulnerabilities as reported by the
Check here for the list. Moving to 1.20.3 for builds solves them all.

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing:

Tested by building locally the affected images.

Special notes for your reviewer:

None

Release note:

NONE

@skonto skonto changed the title Bump the go version for builder image Bump the Go version for the builder image Apr 27, 2023
Signed-off-by: Stavros Kontopoulos <st.kontopoulos@gmail.com>
@skonto
Copy link
Contributor Author

skonto commented Apr 27, 2023

/assign @yuzisun

@yuzisun
Copy link
Member

yuzisun commented Apr 28, 2023

/lgtm
/approve

thanks @skonto !

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzisun yuzisun merged commit d065269 into kserve:master Apr 28, 2023
52 checks passed
Iamlovingit pushed a commit to Iamlovingit/kserve that referenced this pull request Oct 1, 2023
Signed-off-by: Stavros Kontopoulos <st.kontopoulos@gmail.com>
Signed-off-by: iamlovingit <freecode666@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade go images to use 1.20
3 participants