Implement dynamic versioning using poetry plugin #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
andyi2it
force-pushed
the
poetry-plugin
branch
3 times, most recently
from
9fdb66c
to
3d741c5
Compare
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
andyi2it
changed the title
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
yuzisun
reviewed
May 5, 2023
| poetry config installer.parallel true | ||
| - name: Install poetry version plugin | ||
| run: | | ||
| pip install -e python/plugin/poetry-version-plugin |
There was a problem hiding this comment.
Can we install the plug-in with poetry plugin
$ poetry plugin add poetry-version-plugin
|
Discussed with @andyi2it, |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyi2it, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Iamlovingit
pushed a commit
to Iamlovingit/kserve
that referenced
this pull request
Oct 1, 2023
* Added poetry version plugin. Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Removing tests and scripts Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Added poetry plugin installation. Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Fix setup-kserve script. Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Added python verison 3.9 in e2e. Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> --------- Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Signed-off-by: iamlovingit <freecode666@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds provision to install a new poetry plugin from local, thereby dynamically setting the version from a VERSION file.
The plugin should be installed along with poetry using
pip install.The plugin would read the version from the file and dynamically use the version from it for the corresponding packages.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2800
Type of changes
Please delete options that are not relevant.
Release note: