Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break down the Serving and net-istio artifact downloads into their own release trains #2890

Merged
merged 1 commit into from
May 11, 2023

Conversation

matzew
Copy link
Contributor

@matzew matzew commented May 10, 2023

What this PR does / why we need it:

Knative-Serving and Knative's Net-Istio are on a different, independent release train, reflecting this in the quick installer.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

More an enhancement, than a bug fix

Feature/Issue validation/testing:

Changes:

  • introduced new ENV_VARs for Knative_Serving and Knative_Istio, since they have indendent release trains.

[x] Tested by running the quickstart against KinD locally, after the changes

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:


…own release trains

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew matzew changed the title Bbreak down the Serving and net-istio artifact downloads into their own release trains Break down the Serving and net-istio artifact downloads into their own release trains May 10, 2023
@matzew
Copy link
Contributor Author

matzew commented May 10, 2023

CC @aliok

@yuzisun
Copy link
Member

yuzisun commented May 11, 2023

Thanks @matzew !

/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kserve-oss-bot kserve-oss-bot merged commit 5900a68 into kserve:master May 11, 2023
52 checks passed
Iamlovingit pushed a commit to Iamlovingit/kserve that referenced this pull request Oct 1, 2023
…own release trains (kserve#2890)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: iamlovingit <freecode666@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants