Upgrade controller gen version to 0.12.0 #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivanantha321
force-pushed
the
upgrade-controller-gen
branch
from
0af5528
to
1e6ebae
Compare
sivanantha321
force-pushed
the
upgrade-controller-gen
branch
from
1e6ebae
to
9e878a6
Compare
|
Depends on #2914 for go version upgrade |
sivanantha321
force-pushed
the
upgrade-controller-gen
branch
3 times, most recently
from
0d5475c
to
e0c50fb
Compare
sivanantha321
force-pushed
the
upgrade-controller-gen
branch
from
e0c50fb
to
2d6f212
Compare
yuzisun
reviewed
May 24, 2023
| @@ -39,7 +39,7 @@ CONTROLLER_GEN ?= $(LOCALBIN)/controller-gen | |||
|
|
|||
| ## Tool Versions | |||
| KUSTOMIZE_VERSION ?= v5.0.3 | |||
| CONTROLLER_TOOLS_VERSION ?= v0.4.0 | |||
| CONTROLLER_TOOLS_VERSION ?= v0.12.0 | |||
There was a problem hiding this comment.
@sivanantha321 Do we need to regenerate the manifests with this version change?
There was a problem hiding this comment.
yes Dan. I will regenerate the manifests
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
sivanantha321
force-pushed
the
upgrade-controller-gen
branch
from
2d6f212
to
3234c8c
Compare
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
sivanantha321
force-pushed
the
upgrade-controller-gen
branch
from
3234c8c
to
93d3155
Compare
|
Thanks @sivanantha321 ! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sivanantha321, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Iamlovingit
pushed a commit
to Iamlovingit/kserve
that referenced
this pull request
Oct 1, 2023
* Bump controller-gen version to 0.12.0 Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Regenerate manifests Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: iamlovingit <freecode666@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2150
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note: