Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.11 support #2933

Merged
merged 9 commits into from
Jun 3, 2023
Merged

Python 3.11 support #2933

merged 9 commits into from
Jun 3, 2023

Conversation

andyi2it
Copy link
Contributor

@andyi2it andyi2it commented May 23, 2023

What this PR does / why we need it:

Adds support for python 3.11 for supported models.

Support python 3.11 as the github action now defaults to 3.11.
https://github.com/kserve/kserve/actions/runs/5030219298/jobs/9022491447

Which issue(s) this PR fixes :
Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

alibi and paddle does not support python 3.11 at this moment and hence can work only from python 3.8 to 3.10

yuzisun and others added 8 commits May 20, 2023 00:02
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
@andyi2it andyi2it force-pushed the python-3.11-support branch 4 times, most recently from 5f55767 to 700a374 Compare May 26, 2023 11:04
@andyi2it andyi2it marked this pull request as ready for review May 29, 2023 04:24
@andyi2it andyi2it changed the title Do not Merge: Python 3.11 support Python 3.11 support May 29, 2023
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

Excluded alibi test for Python 3.11.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

Updated alibi poetry lock.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

Excluded paddle test for Python 3.11.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

alibi, paddle test should not run for 3.11.X

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
@yuzisun
Copy link
Member

yuzisun commented May 31, 2023

/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyi2it, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzisun yuzisun merged commit d0a877d into kserve:master Jun 3, 2023
55 checks passed
@ddelange ddelange mentioned this pull request Jun 15, 2023
9 tasks
Iamlovingit pushed a commit to Iamlovingit/kserve that referenced this pull request Oct 1, 2023
* Support python 3.11 for kserve sdk

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Update poetry lock file

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Update grpc dependency

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Update sklearn dependency

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Update xgbserver dependency

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Update lgbserver python version

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Update python 3.11

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Updated python version 3.11 for custom model, paddle and alibi.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Upgraded llvmlite version.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

Excluded alibi test for Python 3.11.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

Updated alibi poetry lock.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

Excluded paddle test for Python 3.11.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

alibi, paddle test should not run for 3.11.X

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

---------

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: iamlovingit <freecode666@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants