Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e workflow syntax typo that broke e2e tests #2998

Merged
merged 1 commit into from
Jun 17, 2023

Conversation

andyi2it
Copy link
Contributor

What this PR does / why we need it:
Will fix the broken e2e test

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2997

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Release note:

NONE

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
@yuzisun
Copy link
Member

yuzisun commented Jun 17, 2023

/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyi2it, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzisun yuzisun merged commit 7075f71 into kserve:master Jun 17, 2023
56 checks passed
@andyi2it andyi2it deleted the broken-e2e-fix branch June 17, 2023 04:24
Iamlovingit pushed a commit to Iamlovingit/kserve that referenced this pull request Oct 1, 2023
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Signed-off-by: iamlovingit <freecode666@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

End to End tests are broken because of a typo in workflow file
3 participants