Fix: error response handling for splitter and switch nodes #3116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>
Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>
|
/cc @yuzisun |
Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>
Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>
yuzisun
reviewed
Sep 17, 2023
| @@ -104,40 +104,44 @@ type EnsembleStepOutput struct { | |||
| StepStatusCode int | |||
| } | |||
|
|
|||
| // See if reviewer suggests a better name for this function | |||
| func handleSplitterORSwitchNode(route *v1alpha1.InferenceStep, graph v1alpha1.InferenceGraphSpec, input []byte, headers http.Header) ([]byte, int, error) { | |||
There was a problem hiding this comment.
Why it is only applying to splitter or switch node ? The picked route can be any node type imo
There was a problem hiding this comment.
Sorry for the confusing name of the function. The intent here was ti pull out the common code that was repeating in Splitter and Switch if sections.
There was a problem hiding this comment.
If you look at if-else branches for Sequence and Ensemble, they already have the handling there. I can refactor more in future PRs.
yuzisun
changed the title
|
Thanks @rachitchauhan43 ! Nice tests! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rachitchauhan43, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Iamlovingit
pushed a commit
to Iamlovingit/kserve
that referenced
this pull request
Oct 1, 2023
* Refactoring common code to a function Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com> * Added e2e test cases for splitter nodes Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com> * Fixed linting errors Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com> * Minor refactoring for error message Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com> --------- Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com> Signed-off-by: iamlovingit <freecode666@gmail.com>
ddelange
added a commit
to ddelange/kserve
that referenced
this pull request
Oct 2, 2023
…mp-ray * 'bump-ray' of https://github.com/ddelange/kserve: Bumping version for 0.11.1 (kserve#3141) Fix validation for custom storageUri (kserve#3134) Fix: error response handling for splitter and switch nodes (kserve#3116)
ddelange
added a commit
to ddelange/kserve
that referenced
this pull request
Oct 2, 2023
* 'master' of https://github.com/kserve/kserve: Unpack archive files for hdfs (kserve#3093) Upgrade istio Api and migrate to v1beta1 Api version (kserve#3150) Increase pytest workers for kourier e2e test (kserve#3151) chore: Add design doc template links to feature request template (kserve#3155) Make storage initializer image configurable (kserve#3145) Bumping version for 0.11.1 (kserve#3141) Fix validation for custom storageUri (kserve#3134) Fix: error response handling for splitter and switch nodes (kserve#3116)
ddelange
added a commit
to ddelange/kserve
that referenced
this pull request
Oct 2, 2023
* 'master' of https://github.com/kserve/kserve: Unpack archive files for hdfs (kserve#3093) Upgrade istio Api and migrate to v1beta1 Api version (kserve#3150) Increase pytest workers for kourier e2e test (kserve#3151) chore: Add design doc template links to feature request template (kserve#3155) Make storage initializer image configurable (kserve#3145) Bumping version for 0.11.1 (kserve#3141) Fix validation for custom storageUri (kserve#3134) Fix: error response handling for splitter and switch nodes (kserve#3116)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A bit of refactoring to keep router's code simple.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes: Does a refactoring to add uniformity to Splitter node handling. Also, added e2e tests for splitter node.
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note: