CVE-2023-44487 #3202
Merged
CVE-2023-44487 #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spolti
force-pushed
the
CVE-2023-44487
branch
from
35a9691
to
019c532
Compare
core: Core dependencies update: x/net and grpc Signed-off-by: Spolti <fspolti@redhat.com>
spolti
force-pushed
the
CVE-2023-44487
branch
from
019c532
to
db39944
Compare
israel-hdez
reviewed
Nov 10, 2023
agent.Dockerfile
Outdated
| RUN go mod download | ||
|
|
||
| COPY pkg/ pkg/ | ||
| COPY cmd/ cmd/ | ||
| RUN go mod tidy |
There was a problem hiding this comment.
May you, please, remove changes to this file?
The go mod tidy is more a dev command that should not be called here when doing the build.
There was a problem hiding this comment.
oh yeah, it is a left over that I forgot to remove.
thanks
spolti
commented
Nov 10, 2023
Signed-off-by: Filippe Spolti <filippespolti@gmail.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spolti, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note: