Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused timeout annotation and flag in batcher #3341

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

terrytangyuan
Copy link
Member

This flag is currently missing but batch injector is injecting annotation /batcher-timeout as well as appending --timeout flag to batcher container args.

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
pkg/batcher/handler.go Outdated Show resolved Hide resolved
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan changed the title fix: Add missing --timeout flag in batcher chore: Remove unused timeout annotation and flag in batcher Jan 3, 2024
@yuzisun
Copy link
Member

yuzisun commented Jan 9, 2024

/lgtm
/approve

Copy link

oss-prow-bot bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oss-prow-bot oss-prow-bot bot added the approved label Jan 9, 2024
@oss-prow-bot oss-prow-bot bot merged commit 53dcf51 into kserve:master Jan 9, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants