Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes CVE-2023-48795 #3354

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Fixes CVE-2023-48795 #3354

merged 2 commits into from
Jan 12, 2024

Conversation

spolti
Copy link
Contributor

@spolti spolti commented Jan 8, 2024

The crypto is pulled from go/compute which is pulled by go/storage
https://github.com/googleapis/google-cloud-go/tree/main/storage

Fixes CVE-2023-48795 - golang.org/x/crypto Authentication Bypass by Capture-replay

chore: Fixes [CVE-2023-48795](https://www.cve.org/CVERecord?id=CVE-2023-48795) - golang.org/x/crypto Authentication Bypass by Capture-replay

Signed-off-by: Spolti <fspolti@redhat.com>
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@israel-hdez
Copy link
Contributor

Not sure how important it is, but running go mod tidy would remove a few lines from go.sum.

@terrytangyuan
Copy link
Member

Could you run a go mod tidy and commit those changes as well? @spolti

@spolti
Copy link
Contributor Author

spolti commented Jan 9, 2024

Not sure how important it is, but running go mod tidy would remove a few lines from go.sum.

It is, I always forget to run it, thanks for the reminder.

Signed-off-by: Spolti <fspolti@redhat.com>
@terrytangyuan
Copy link
Member

/lgtm

@terrytangyuan
Copy link
Member

/assign @yuzisun

@yuzisun
Copy link
Member

yuzisun commented Jan 12, 2024

/approve

Copy link

oss-prow-bot bot commented Jan 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spolti, terrytangyuan, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oss-prow-bot oss-prow-bot bot merged commit 1548604 into kserve:master Jan 12, 2024
58 checks passed
@spolti spolti deleted the CVE-2023-48795 branch January 13, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants