Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add HuggingFace runtime out-of-the-box support #3395

Merged
merged 8 commits into from Feb 10, 2024
Merged

feat: Add HuggingFace runtime out-of-the-box support #3395

merged 8 commits into from Feb 10, 2024

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Jan 30, 2024 •
edited

Part of #3393.

  • Tests
  • Update Python spec
  • Regenerate manifests

@terrytangyuan
feat: Add HuggingFace runtime out-of-the-box support
4775610 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
Update violation list
c1cba46 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
Add to charts
bcc7c50 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
Regenerate everything
909d7e8 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
fix lint
2f8c168 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan mentioned this pull request Feb 5, 2024
Closed
@terrytangyuan
fix lint
89967c3 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
Empty-Commit
1d0bf3f 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
Empty-Commit
9c58eb8 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan changed the title [WIP] feat: Add HuggingFace runtime out-of-the-box support feat: Add HuggingFace runtime out-of-the-box support Feb 6, 2024
@terrytangyuan terrytangyuan marked this pull request as ready for review February 6, 2024 17:41
yuzisun
yuzisun reviewed Feb 7, 2024
View reviewed changes
pkg/apis/serving/v1beta1/predictor.go
@@ -44,6 +44,8 @@ type PredictorSpec struct {
Triton *TritonSpec `json:"triton,omitempty"`
// Spec for ONNX runtime (https://github.com/microsoft/onnxruntime)
ONNX *ONNXRuntimeSpec `json:"onnx,omitempty"`
// Spec for HuggingFace runtime (https://github.com/huggingface)
HuggingFace *HuggingFaceRuntimeSpec `json:"huggingface,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we are trying to deprecate these individually defined runtime types as we are moving users to the model spec instead. @sivanantha321 has a PR for this #3144

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I am aware of that PR and thought about it as well. IMO we should include this for consistency (better UX) and then deprecate all the individually defined runtimes together later as part of #3144.

@yuzisun
Copy link
Member

yuzisun commented Feb 9, 2024

@terrytangyuan Looks great! can you help add an e2e test?

@yuzisun
Copy link
Member

yuzisun commented Feb 10, 2024

/lgtm
/approve

@oss-prow-bot oss-prow-bot bot added the lgtm label Feb 10, 2024
@oss-prow-bot OSS-prow-bot
Copy link

oss-prow-bot bot commented Feb 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzisun yuzisun merged commit 5c452e7 into kserve:master Feb 10, 2024
60 checks passed
@terrytangyuan terrytangyuan deleted the hf-runtime branch February 10, 2024 15:01
@terrytangyuan terrytangyuan mentioned this pull request Feb 12, 2024
Merged
7 tasks
TimKleinloog pushed a commit to TimKleinloog/kserve that referenced this pull request Feb 13, 2024
@terrytangyuan @TimKleinloog
feat: Add HuggingFace runtime out-of-the-box support (kserve#3395)
3c67d89 
* feat: Add HuggingFace runtime out-of-the-box support

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Update violation list

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Add to charts

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Regenerate everything

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* fix lint

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* fix lint

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Empty-Commit

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Empty-Commit

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

---------

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Tim Kleinloog <tkleinloog@deeploy.ml>
@terrytangyuan terrytangyuan mentioned this pull request Feb 14, 2024
Merged
TimKleinloog pushed a commit to TimKleinloog/kserve that referenced this pull request Feb 19, 2024
@terrytangyuan @TimKleinloog
feat: Add HuggingFace runtime out-of-the-box support (kserve#3395)
bd53576 
* feat: Add HuggingFace runtime out-of-the-box support

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Update violation list

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Add to charts

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Regenerate everything

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* fix lint

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* fix lint

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Empty-Commit

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Empty-Commit

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

---------

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Tim Kleinloog <tkleinloog@deeploy.ml>
TimKleinloog pushed a commit to TimKleinloog/kserve that referenced this pull request Feb 20, 2024
@terrytangyuan @TimKleinloog
feat: Add HuggingFace runtime out-of-the-box support (kserve#3395)
79babfc 
* feat: Add HuggingFace runtime out-of-the-box support

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Update violation list

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Add to charts

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Regenerate everything

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* fix lint

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* fix lint

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Empty-Commit

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Empty-Commit

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

---------

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Tim Kleinloog <tkleinloog@deeploy.ml>
TimKleinloog pushed a commit to TimKleinloog/kserve that referenced this pull request Feb 20, 2024
@terrytangyuan @TimKleinloog
feat: Add HuggingFace runtime out-of-the-box support (kserve#3395)
e071c0f 
* feat: Add HuggingFace runtime out-of-the-box support

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Update violation list

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Add to charts

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Regenerate everything

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* fix lint

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* fix lint

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Empty-Commit

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Empty-Commit

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

---------

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
timothyjlaurent pushed a commit to timothyjlaurent/kserve that referenced this pull request Feb 21, 2024
@terrytangyuan @timothyjlaurent
feat: Add HuggingFace runtime out-of-the-box support (kserve#3395)
6ea74b5 
* feat: Add HuggingFace runtime out-of-the-box support

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Update violation list

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Add to charts

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Regenerate everything

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* fix lint

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* fix lint

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Empty-Commit

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Empty-Commit

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

---------

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@pbasov pbasov mentioned this pull request Feb 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzisun yuzisun yuzisun left review comments

@sivanantha321 sivanantha321 sivanantha321 left review comments

@adriangonz adriangonz Awaiting requested review from adriangonz

@andyi2it andyi2it Awaiting requested review from andyi2it

@theofpa theofpa Awaiting requested review from theofpa

Assignees

@yuzisun yuzisun

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@terrytangyuan @yuzisun @sivanantha321