fix: Instantiate HuggingfaceModelRepository only when model cannot be loaded. Fixes #3423 #3424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… loaded. Fixes kserve#3423 Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
|
/lgtm |
@sivanantha321 Should we make the same fix to other model servers like sklearn as well ? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
9 tasks
tjandy98
pushed a commit
to tjandy98/kserve
that referenced
this pull request
Apr 10, 2024
… loaded. Fixes kserve#3423 (kserve#3424) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3423