Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add helm docs update to make generate command #3437

Merged
merged 7 commits into from
Mar 1, 2024

Conversation

terrytangyuan
Copy link
Member

This automates helm docs generation as part of the existing make generate command.

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan (Terry) Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
Copy link
Member Author

Updated.

/assign @yuzisun

@yuzisun
Copy link
Member

yuzisun commented Feb 29, 2024

/approve

Copy link

oss-prow-bot bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzisun
Copy link
Member

yuzisun commented Feb 29, 2024

/lgtm

@oss-prow-bot oss-prow-bot bot added the lgtm label Feb 29, 2024
@yuzisun yuzisun merged commit b119f54 into kserve:master Mar 1, 2024
58 checks passed
@terrytangyuan terrytangyuan deleted the update-docs branch March 1, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants