Fix: Support model parallelism in HF transformer #3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnugeorge
reviewed
Feb 20, 2024
9 tasks
Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>
Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>
Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>
Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>
Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>
Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>
Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>
Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>
Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>
Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>
gavrishp
force-pushed
the
hf_distributed
branch
from
74ef248
to
7ed7893
Compare
yuzisun
reviewed
Mar 3, 2024
Comment on lines
+123
to
+124
| if self.model._no_split_modules: | ||
| self.device_map = "auto" |
There was a problem hiding this comment.
should we call infer_auto_device_map here?
There was a problem hiding this comment.
There was a problem hiding this comment.
I think the functionality wise it's the same
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gavrishp, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Mar 21, 2024
9 tasks
tjandy98
pushed a commit
to tjandy98/kserve
that referenced
this pull request
Apr 10, 2024
* Support model parallelism in HF transformer Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com> * Support models that dont supoort slipt Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com> * fix padding Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com> * fix defauults Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com> * set cuda as default Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com> * set cuda as default Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com> * fix lint Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com> * update automodel Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com> * fix review comment Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com> * update review comment Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com> * update comment Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com> --------- Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com> Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Include device_map changes and set it to "auto" to allow model parallelism prevent from OOM trying to fit model into a single device
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Tested with large models like in llama2 70B
Checklist:
Release note: