Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conversion webhook from manifests #3476

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

Jooho
Copy link
Contributor

@Jooho Jooho commented Feb 23, 2024

What this PR does / why we need it:
At the moment, kserve does not have the conversion webhook so we don't need the conversion webhook related information from manifests

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # #3344

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:


Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of commenting out, we can probably remove them directly from the YAML.

@Jooho
Copy link
Contributor Author

Jooho commented Feb 26, 2024

@terrytangyuan this is a kind of conversion webhook template and afaik, there is a plan to upgrade api version near future so I think it is okay to have the reference. However, I am okay with removing it for now.

@Jooho
Copy link
Contributor Author

Jooho commented Feb 26, 2024

@ckadner could you please retrigger the failed test?

@terrytangyuan
Copy link
Member

/retest

@ckadner
Copy link
Member

ckadner commented Feb 27, 2024

Instead of commenting out, we can probably remove them directly from the YAML.

I would agree

@Jooho:

there is a plan to upgrade api version near future so I think it is okay to have the reference

would you have a link to an issue or Slack discussion? or maybe KServe meeting doc?

@Jooho
Copy link
Contributor Author

Jooho commented Feb 27, 2024

@ckadner from meeting note, https://docs.google.com/document/d/1KZUURwr9MnHXqHA08TFbfVbM8EAJSJjmaMhnvstvi-k/edit

KServe 1.0 planning
Inference service v1beta1 -> v1
Serving runtime v1alpha1 -> v1beta1
Inference Graph v1alpha1 -> v1beta1

@Jooho
Copy link
Contributor Author

Jooho commented Feb 27, 2024

@terrytangyuan @ckadner I deleted related parts and files.

@israel-hdez
Copy link
Contributor

this is a kind of conversion webhook template and afaik, there is a plan to upgrade api version near future so I think it is okay to have the reference. However, I am okay with removing it for now.

I think we should be able to re-generate these artifacts with kubebuilder. So, I'm also +1 on removing.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- just one tiny nit pick on trailing whitespace

config/default/kustomization.yaml Outdated Show resolved Hide resolved
Signed-off-by: jooho <jlee@redhat.com>
@Jooho Jooho force-pushed the remove_conversion_webhook branch from 459ef66 to c460eaa Compare March 5, 2024 17:27
@oss-prow-bot oss-prow-bot bot removed the lgtm label Mar 5, 2024
@yuzisun
Copy link
Member

yuzisun commented Mar 9, 2024

/lgtm
/approve

Copy link

oss-prow-bot bot commented Mar 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jooho, terrytangyuan, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oss-prow-bot oss-prow-bot bot added the approved label Mar 9, 2024
@oss-prow-bot oss-prow-bot bot merged commit df889a1 into kserve:master Mar 9, 2024
58 checks passed
tjandy98 pushed a commit to tjandy98/kserve that referenced this pull request Apr 10, 2024
Signed-off-by: jooho <jlee@redhat.com>
Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com>
israel-hdez added a commit to israel-hdez/modelmesh-serving that referenced this pull request Apr 10, 2024
Reference: kserve/kserve#3476

Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
israel-hdez added a commit to israel-hdez/modelmesh-serving that referenced this pull request Apr 10, 2024
Reference: kserve/kserve#3476

Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
israel-hdez pushed a commit to israel-hdez/kserve that referenced this pull request May 4, 2024
Signed-off-by: jooho <jlee@redhat.com>
israel-hdez pushed a commit to israel-hdez/kserve that referenced this pull request May 6, 2024
Signed-off-by: jooho <jlee@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants