-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove conversion webhook from manifests #3476
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of commenting out, we can probably remove them directly from the YAML.
@terrytangyuan this is a kind of conversion webhook template and afaik, there is a plan to upgrade api version near future so I think it is okay to have the reference. However, I am okay with removing it for now. |
@ckadner could you please retrigger the failed test? |
/retest |
I would agree
would you have a link to an issue or Slack discussion? or maybe KServe meeting doc? |
@ckadner from meeting note, https://docs.google.com/document/d/1KZUURwr9MnHXqHA08TFbfVbM8EAJSJjmaMhnvstvi-k/edit
|
ef03f37
to
459ef66
Compare
@terrytangyuan @ckadner I deleted related parts and files. |
I think we should be able to re-generate these artifacts with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- just one tiny nit pick on trailing whitespace
Signed-off-by: jooho <jlee@redhat.com>
459ef66
to
c460eaa
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jooho, terrytangyuan, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: jooho <jlee@redhat.com> Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com>
Reference: kserve/kserve#3476 Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
Reference: kserve/kserve#3476 Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
Signed-off-by: jooho <jlee@redhat.com>
Signed-off-by: jooho <jlee@redhat.com>
What this PR does / why we need it:
At the moment, kserve does not have the conversion webhook so we don't need the conversion webhook related information from manifests
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes # #3344
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note: