Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support customizable deployment spec for RawDeployment mode #3479

Closed
wants to merge 14 commits into from
Closed

feat: Support customizable deployment spec for RawDeployment mode #3479

wants to merge 14 commits into from

Conversation

terrytangyuan
Copy link
Member

Fixes #3452.

@terrytangyuan
feat: Support customizable deployment spec for RawDeployment mode
e26a622 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@oss-prow-bot OSS-prow-bot
Copy link

oss-prow-bot bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: terrytangyuan
Once this PR has been reviewed and has the lgtm label, please assign rachitchauhan43 for approval by writing /assign @rachitchauhan43 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@terrytangyuan
goimports
e3ef0be 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan marked this pull request as draft February 26, 2024 15:42
@terrytangyuan
codegen
fc922a5 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
go mod tidy
7496db0 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
fix test
71d00bc 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
handle labels
cfaa5d3 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
test
ebbcfca 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
test template
d36491d 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
move away from inline required
3ec37fc 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
Add a test case
533603d 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
fix test
cca68ca 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
Bump isvc name
e39570b 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
fix test case
31bad84 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
print out crd for debugging
7e82dc3 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan mentioned this pull request Feb 28, 2024
Closed
yuzisun
yuzisun reviewed Mar 3, 2024
View reviewed changes
pkg/apis/serving/v1beta1/component.go

// RawDeploymentSpec customizes the deployment configuration for the predictor when using RawDeployment mode.
// +optional
RawDeploymentSpec *appsv1.DeploymentSpec `json:"rawDeploymentSpec,omitempty"`
Copy link
Member

@yuzisun yuzisun Mar 3, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss the design, there are conflicting fields with Serverless mode(Knative).. Knative does not allow setting deploymentStrategy, replica.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this includes the entire podTemplate field which is dup of PodSpec on the component

@terrytangyuan terrytangyuan mentioned this pull request Mar 16, 2024
Open
@terrytangyuan terrytangyuan mentioned this pull request Apr 15, 2024
Merged
@terrytangyuan
Copy link
Member Author

Closing in favor of the new approach #3603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzisun yuzisun yuzisun left review comments

@njhill njhill Awaiting requested review from njhill

@theofpa theofpa Awaiting requested review from theofpa

Assignees
No one assigned
Labels
do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to change parameters of of the default Deployment created from ServingRuntime and InferenceService
2 participants
@terrytangyuan @yuzisun