feat: Provide minimal distribution of CRDs #3492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrytangyuan
changed the title
terrytangyuan
changed the title
yuzisun
reviewed
Mar 12, 2024
yuzisun
reviewed
Mar 12, 2024
terrytangyuan
force-pushed
the
reduce-crds
branch
from
1d89b47
to
aab3556
Compare
|
@yuzisun Addressed comments. PTAL. |
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
terrytangyuan
force-pushed
the
reduce-crds
branch
from
aab3556
to
499018a
Compare
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
|
@yuzisun @sivanantha321 Just rebased and resolved conflicts after the merge of #3443. |
|
I am just curious, How is the validation handled for minimal crd version. Is it through validation webhook ? |
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
|
@sivanantha321 Yes and basically leave that responsibility to something else, e.g. front-end, validation webhook, etc. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3487.
Trying out a similar approach to what we are doing for Argo Workflows https://github.com/argoproj/argo-workflows