Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cert manager version in quick install script #3496

Merged

Conversation

shauryagoel
Copy link
Contributor

What this PR does / why we need it:
Update the cert manager version to v1.9.0 in the quick_install.sh script. In the documentation, we are advised to use v1.9.0, however in the quick_install.sh script, an old version (v1.3.0) of the cert manager is being used.

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Signed-off-by: Shaurya Goel <shauryagoel0@gmail.com>
@shauryagoel shauryagoel force-pushed the quick-install-cert-manager-update branch from 628bd07 to 2b69d02 Compare March 3, 2024 13:17
@yuzisun
Copy link
Member

yuzisun commented Mar 7, 2024

/lgtm
/approve

Copy link

oss-prow-bot bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shauryagoel, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oss-prow-bot oss-prow-bot bot added the approved label Mar 7, 2024
@oss-prow-bot oss-prow-bot bot merged commit b0fef32 into kserve:master Mar 7, 2024
58 checks passed
tjandy98 pushed a commit to tjandy98/kserve that referenced this pull request Apr 10, 2024
Signed-off-by: Shaurya Goel <shauryagoel0@gmail.com>
Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants