Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Bump minikube version to work with newer K8s version #3498

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

terrytangyuan
Copy link
Member

This warning is on CI builds due to unsupported combination between Minikube and K8s versions and CI sometimes has issue to set up minikube + K8s. Example: https://github.com/kserve/kserve/actions/runs/8145181761/job/22261191715?pr=3443

/home/runner/bin/minikube start --cni calico --driver none --kubernetes-version v1.27.4 --network-plugin cni --wait all --wait-timeout=6m0s
* minikube v1.31.1 on Ubuntu 22.04
! Specified Kubernetes version 1.27.4 is newer than the newest supported version: v1.27.3. Use `minikube config defaults kubernetes-version` for details.

Upgrading minikube could potentially help alleviate this issue from happening frequently.

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@sivanantha321
Copy link
Member

/lgtm

@yuzisun
Copy link
Member

yuzisun commented Mar 8, 2024

/approve

Copy link

oss-prow-bot bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sivanantha321, terrytangyuan, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oss-prow-bot oss-prow-bot bot added the approved label Mar 8, 2024
@oss-prow-bot oss-prow-bot bot merged commit a99e451 into kserve:master Mar 8, 2024
45 checks passed
@terrytangyuan terrytangyuan deleted the bump-minikube branch March 8, 2024 02:26
tjandy98 pushed a commit to tjandy98/kserve that referenced this pull request Apr 10, 2024
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants