Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a typo in OPENSHIFT_GUIDE.md #3544

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Conversation

marek-veber
Copy link
Contributor

What this PR does / why we need it:
This is a intuitive small typo fix.

Which issue(s) this PR fixes:
Fixes #3543

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Feature/Issue validation/testing:
Test if the fixed link points to valid page.

Release note:

 * fix a typo in OPENSHIFT_GUIDE.md

@sivanantha321
Copy link
Member

/lgtm

@sivanantha321
Copy link
Member

@marek-veber Thanks for the fix ! Can you help sign-off the commit to pass the DCO check ?

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yuzisun
Copy link
Member

yuzisun commented Mar 24, 2024

/approve

Copy link

oss-prow-bot bot commented Mar 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marek-veber, sivanantha321, terrytangyuan, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oss-prow-bot oss-prow-bot bot merged commit a98e22d into kserve:master Mar 24, 2024
45 checks passed
tjandy98 pushed a commit to tjandy98/kserve that referenced this pull request Apr 10, 2024
Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com>
israel-hdez pushed a commit to israel-hdez/kserve that referenced this pull request May 3, 2024
israel-hdez pushed a commit to israel-hdez/kserve that referenced this pull request May 4, 2024
israel-hdez pushed a commit to israel-hdez/kserve that referenced this pull request May 4, 2024
israel-hdez pushed a commit to israel-hdez/kserve that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is an invalid link in OPENSHIFT_GUIDE.md
4 participants