Update codeQL to v3 #3548
Merged
Update codeQL to v3 #3548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: Update CodeQL to V3 to get rid of this warning: `Warning: CodeQL Action v2 will be deprecated on December 5th, 2024` Plus, attenpt to fix the Snyk Container scan failures due errors when trying to upload the SERIF file: `Processing sarif files: ["application/storage-initializer/docker.snyk.sarif"] Uploading results Successfully uploaded results Waiting for processing to finish Error: Code Scanning could not process the submitted SARIF file: could not convert rules: invalid security severity value, is not a number: null ConfigurationError: Code Scanning could not process the submitted SARIF file: could not convert rules: invalid security severity value, is not a number: null at run (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-sarif-action.js:65:15)` Signed-off-by: Spolti <fspolti@redhat.com>
| @@ -45,7 +45,8 @@ jobs: | |||
|
|
|||
| - name: Upload sarif file to Github Code Scanning | |||
| if: always() | |||
| uses: github/codeql-action/upload-sarif@v2 | |||
| continue-on-error: true #avoid fail the pipeline if the SARIF upload fails. | |||
There was a problem hiding this comment.
What are some example upload failures?
There was a problem hiding this comment.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spolti, terrytangyuan, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tjandy98
pushed a commit
to tjandy98/kserve
that referenced
this pull request
Apr 10, 2024
update codeQL to v3 chore: Update CodeQL to V3 to get rid of this warning: `Warning: CodeQL Action v2 will be deprecated on December 5th, 2024` Plus, attenpt to fix the Snyk Container scan failures due errors when trying to upload the SERIF file: `Processing sarif files: ["application/storage-initializer/docker.snyk.sarif"] Uploading results Successfully uploaded results Waiting for processing to finish Error: Code Scanning could not process the submitted SARIF file: could not convert rules: invalid security severity value, is not a number: null ConfigurationError: Code Scanning could not process the submitted SARIF file: could not convert rules: invalid security severity value, is not a number: null at run (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-sarif-action.js:65:15)` Signed-off-by: Spolti <fspolti@redhat.com> Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: Update CodeQL to V3 to get rid of this warning:
Warning: CodeQL Action v2 will be deprecated on December 5th, 2024Plus, attenpt to fix the Snyk Container scan failures due errors when trying to
upload the SERIF file:
Release note: