Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set writable cache folder to avoid permission issue. Fixes #3562 #3576

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

terrytangyuan
Copy link
Member

Fixes #3562

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Copy link
Member

@lizzzcai lizzzcai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@oss-prow-bot oss-prow-bot bot removed the lgtm label Apr 8, 2024
@terrytangyuan
Copy link
Member Author

@lizzzcai Could you LGTM again? Had to push an empty commit to pass flaky build.

@lizzzcai
Copy link
Member

lizzzcai commented Apr 8, 2024

/lgtm

@oss-prow-bot oss-prow-bot bot added the lgtm label Apr 8, 2024
@yuzisun
Copy link
Member

yuzisun commented Apr 9, 2024

/approve

Copy link

oss-prow-bot bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lizzzcai, spolti, terrytangyuan, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oss-prow-bot oss-prow-bot bot added the approved label Apr 9, 2024
@yuzisun yuzisun merged commit d0cb667 into kserve:master Apr 9, 2024
56 checks passed
tjandy98 pushed a commit to tjandy98/kserve that referenced this pull request Apr 10, 2024
…e#3562 (kserve#3576)

* Set writable cache folder to avoid permission issue. Fixes kserve#3562

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Update huggingface_server.Dockerfile

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Empty-Commit

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

---------

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Huggingface server fails to start on OpenShift cluster
4 participants