-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a user friendly error message for http exceptions #3581
Conversation
abc7a43
to
0b1f95f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
/hold |
@terrytangyuan removed logging for potentially sensitive data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Can you sign DCO? |
Yes, signing the DCO in a minute. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition, thanks!
Signed-off-by: grandbora <grandbora@fb.com>
@terrytangyuan signed the DCO. Thank you. |
/lgtm |
/assign @jinchihe |
@jinchihe would you mind approving this pr? |
@jinchihe @terrytangyuan @yuzisun is there anything else needs to be done for this pr? |
/unhold |
/assign @yuzisun |
/unassign @terrytangyuan |
/meow |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@grandbora You'll have to be a little more patient since the only active approver is @yuzisun right now. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grandbora, spolti, terrytangyuan, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Adds a user friendly error message to http exceptions that may happen when sending requests to the predictor node.
Example error log:
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Tested locally. Spun up a transformer and pointed it to a wrong url. Generated the log message above.
Special notes for your reviewer:
No image changes.
Checklist:
Release note:
Not worth of a release note.