Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default SAFETENSORS_FAST_GPU and HF_HUB_DISABLE_TELEMETRY in HF Server #3594

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

lizzzcai
Copy link
Member

What this PR does / why we need it:

set SAFETENSORS_FAST_GPU=1 and HF_HUB_DISABLE_TELEMETRY=1.

SAFETENSORS_FAST_GPU: seems can improve the model loading time from HF example (direct copy to GPU).
HF_HUB_DISABLE_TELEMETRY: HF has enabled telemetry by default. It is a bit sensitive and the user may not know it. Just disable it by default and if the user wants it can enable it by overwriting the value.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:


Signed-off-by: Lize Cai <lize.cai@sap.com>
@oss-prow-bot oss-prow-bot bot requested review from ckadner and yuzisun April 11, 2024 10:14
@spolti
Copy link
Contributor

spolti commented Apr 11, 2024

Does it make sense to add this information in the docs?

Signed-off-by: Lize Cai <lize.cai@sap.com>
@lizzzcai
Copy link
Member Author

Does it make sense to add this information in the docs?

added to the hf runtime README.

@yuzisun
Copy link
Member

yuzisun commented Apr 29, 2024

/lgtm
/approve

Copy link

oss-prow-bot bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lizzzcai, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzisun yuzisun merged commit 1c5b0f9 into kserve:master Apr 29, 2024
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants