Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test image builds for ARM64 arch in CI #3629

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

sivanantha321
Copy link
Member

@sivanantha321 sivanantha321 commented Apr 24, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:

NONE

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
@sivanantha321 sivanantha321 force-pushed the add--arm64-build-check branch 2 times, most recently from 740bb69 to ab913ec Compare April 24, 2024 08:20
fi
uses: docker/build-push-action@v5
with:
platforms: linux/amd64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some places there still only amd64, is it due compatibility with dependencies for arm?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is for custom model and transformer which is only servers as an example. We will have to add ARM support for huggingface in a separate PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any issue with the ARM build for huggingface server?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah

#8 0.202 exec /bin/sh: exec format error
#8 ERROR: process "/bin/sh -c apt-get update -y && apt-get install python3.10-venv -y && apt-get clean &&     rm -rf /var/lib/apt/lists/*" did not complete successfully: exit code: 1

#5 [builder  1/13] FROM docker.io/nvidia/cuda:12.1.0-devel-ubuntu22.04@sha256:e3a8f7b933e77ecee74731198a2a5483e965b585cea2660675cf4bb152237e9b
#5 CANCELED
------
 > [prod 2/7] RUN apt-get update -y && apt-get install python3.10-venv -y && apt-get clean &&     rm -rf /var/lib/apt/lists/*:
0.202 exec /bin/sh: exec format error
------
huggingface_server.Dockerfile:39

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, my docker builder is not configured properly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like vllm does not provides arm64 wheels

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Copy link
Contributor

@spolti spolti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sivanantha321
Copy link
Member Author

@yuzisun Can you verify auto merge works with this change ?

@yuzisun
Copy link
Member

yuzisun commented Apr 30, 2024

@yuzisun Can you verify auto merge works with this change ?

Sure, what was the fix?

@sivanantha321
Copy link
Member Author

@yuzisun Can you verify auto merge works with this change ?

Sure, what was the fix?

There is not any explicit fix. Those custom transformer workflows uses actions now instead of manual push. I just wanted to know if it is affects the auto merge.

@yuzisun
Copy link
Member

yuzisun commented Apr 30, 2024

/approve

Copy link

oss-prow-bot bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sivanantha321, spolti, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzisun
Copy link
Member

yuzisun commented Apr 30, 2024

@yuzisun Can you verify auto merge works with this change ?

Sure, what was the fix?

There is not any explicit fix. Those custom transformer workflows uses actions now instead of manual push. I just wanted to know if it is affects the auto merge.

seems like it did not work

@yuzisun yuzisun merged commit 8cfb3e0 into kserve:master Apr 30, 2024
56 of 57 checks passed
asd981256 pushed a commit to asd981256/kserve that referenced this pull request May 14, 2024
* Test image builds for ARM64 arch in CI

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Update lockfiles

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Add ARM64 support for paddle

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: asd981256 <asd981256@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants