-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test image builds for ARM64 arch in CI #3629
Conversation
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
740bb69
to
ab913ec
Compare
fi | ||
uses: docker/build-push-action@v5 | ||
with: | ||
platforms: linux/amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some places there still only amd64, is it due compatibility with dependencies for arm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is for custom model and transformer which is only servers as an example. We will have to add ARM support for huggingface in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any issue with the ARM build for huggingface server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah
#8 0.202 exec /bin/sh: exec format error
#8 ERROR: process "/bin/sh -c apt-get update -y && apt-get install python3.10-venv -y && apt-get clean && rm -rf /var/lib/apt/lists/*" did not complete successfully: exit code: 1
#5 [builder 1/13] FROM docker.io/nvidia/cuda:12.1.0-devel-ubuntu22.04@sha256:e3a8f7b933e77ecee74731198a2a5483e965b585cea2660675cf4bb152237e9b
#5 CANCELED
------
> [prod 2/7] RUN apt-get update -y && apt-get install python3.10-venv -y && apt-get clean && rm -rf /var/lib/apt/lists/*:
0.202 exec /bin/sh: exec format error
------
huggingface_server.Dockerfile:39
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm, my docker builder is not configured properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like vllm does not provides arm64 wheels
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
ab913ec
to
ea753de
Compare
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@yuzisun Can you verify auto merge works with this change ? |
Sure, what was the fix? |
There is not any explicit fix. Those custom transformer workflows uses actions now instead of manual push. I just wanted to know if it is affects the auto merge. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sivanantha321, spolti, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
seems like it did not work |
* Test image builds for ARM64 arch in CI Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Update lockfiles Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Add ARM64 support for paddle Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: asd981256 <asd981256@gmail.com>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note: