Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker build failures for arm64 and restrict ray serve to ~2.10.0 #3630

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
602 changes: 300 additions & 302 deletions python/aiffairness/poetry.lock

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion python/artexplainer.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ ARG POETRY_HOME=/opt/poetry
ARG POETRY_VERSION=1.7.1

# Required for building packages for arm64 arch
RUN apt-get update && apt-get install -y --no-install-recommends python3-dev build-essential
RUN apt-get update && apt-get install -y --no-install-recommends python3-dev build-essential pkg-config libhdf5-dev && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for arm we could pin the h5py version to 2.10 (IIRC) instead doing it here.
wdyt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already doing some compiling for ARM64 and after reading the comment here I am not sure when the ARM builds will be available.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, for now we could stick with 3.10 and wait for that. =/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still can use h5py with newer python versions, right?

apt-get clean && rm -rf /var/lib/apt/lists/*

RUN python3 -m venv ${POETRY_HOME} && ${POETRY_HOME}/bin/pip install poetry==${POETRY_VERSION}
ENV PATH="$PATH:${POETRY_HOME}/bin"
Expand Down
1,017 changes: 506 additions & 511 deletions python/artexplainer/poetry.lock

Large diffs are not rendered by default.

791 changes: 395 additions & 396 deletions python/custom_model/poetry.lock

Large diffs are not rendered by default.

658 changes: 328 additions & 330 deletions python/custom_tokenizer/poetry.lock

Large diffs are not rendered by default.

797 changes: 398 additions & 399 deletions python/custom_transformer/poetry.lock

Large diffs are not rendered by default.

686 changes: 351 additions & 335 deletions python/huggingfaceserver/poetry.lock

Large diffs are not rendered by default.

501 changes: 259 additions & 242 deletions python/kserve/poetry.lock

Large diffs are not rendered by default.

5 changes: 1 addition & 4 deletions python/kserve/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,7 @@ kubernetes = ">=23.3.0"
python-dateutil = "^2.8.0"
numpy = "^1.23.5"
psutil = "^5.9.0"
ray = { version = "^2.10.0", extras = ["serve"] }
async-timeout = { version = "^4.0.3", python = "==3.11.*" }
ray = { version = "~2.10.0", extras = ["serve"] }
grpcio = "^1.49.1"
protobuf = "^3.19.0"
prometheus-client = "^0.20.0"
Expand All @@ -55,7 +54,6 @@ pandas = ">=1.3.5"
pydantic = ">1.0,<3"

# Storage dependencies. They can be opted into by apps.
urllib3 = { version = "^1.26.8", optional = true }
requests = { version = "^2.20.0", optional = true }
google-cloud-storage = { version = "^2.3.0", optional = true }
azure-storage-blob = { version = "^12.10.0", optional = true }
Expand All @@ -68,7 +66,6 @@ asgi-logger = { version = "^0.1.0", optional = true, python = ">3.8.0,<3.11" }

[tool.poetry.extras]
storage = [
"urllib3",
"requests",
"google-cloud-storage",
"azure-storage-blob",
Expand Down
664 changes: 339 additions & 325 deletions python/lgbserver/poetry.lock

Large diffs are not rendered by default.

789 changes: 402 additions & 387 deletions python/paddleserver/poetry.lock

Large diffs are not rendered by default.

772 changes: 393 additions & 379 deletions python/pmmlserver/poetry.lock

Large diffs are not rendered by default.

658 changes: 336 additions & 322 deletions python/sklearnserver/poetry.lock

Large diffs are not rendered by default.

652 changes: 325 additions & 327 deletions python/test_resources/graph/error_404_isvc/poetry.lock

Large diffs are not rendered by default.

652 changes: 325 additions & 327 deletions python/test_resources/graph/success_200_isvc/poetry.lock

Large diffs are not rendered by default.

658 changes: 336 additions & 322 deletions python/xgbserver/poetry.lock

Large diffs are not rendered by default.

Loading