Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Remove misleading logs from minimal-crdgen.sh #3641

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

terrytangyuan
Copy link
Member

The current logs are misleading which may look like both the minimal and full CRDs are applied to the cluster twice:

./hack/minimal-crdgen.sh
Patching config/crd/full/serving.kserve.io_servingruntimes.yaml
Creating config/crd/minimal/serving.kserve.io_servingruntimes.yaml

The PR makes it less confusing.

/cc @yuzisun

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@oss-prow-bot oss-prow-bot bot requested a review from yuzisun April 28, 2024 02:32
@yuzisun
Copy link
Member

yuzisun commented Apr 28, 2024

/lgtm
/approve

Copy link

oss-prow-bot bot commented Apr 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzisun yuzisun merged commit 5b51837 into kserve:master Apr 28, 2024
56 of 57 checks passed
@terrytangyuan terrytangyuan deleted the fix-misleading-log branch April 28, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants