Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow file for cherry-pick on comment #3653

Merged
merged 3 commits into from
May 4, 2024

Conversation

andyi2it
Copy link
Contributor

@andyi2it andyi2it commented Apr 29, 2024

What this PR does / why we need it:

This PR would allow cherry picking a PR and create a new PR on a target branch. Example, if a new critical fix was added to master, one can add a comment to cherry-pick to release-branch.
At this moment it is configured to allow only repo owner to cherry-pick.

Usage:

/cherry-pick release-branch

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3656

Release note:

NONE

Re-running failed tests

  • /rerun-all - rerun all failed workflows.
  • /rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
@israel-hdez
Copy link
Contributor

There is already a cherry-pick workflow: https://github.com/kserve/kserve/blob/master/.github/workflows/cherry-pick.yml
I see it as outdated. Maybe, we should replace/update that one instead of creating a new file?

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be great to have.

@yuzisun
Copy link
Member

yuzisun commented May 1, 2024

@andyi2it Can you help add the instruction for how to cherry pick the commits to the release doc ?

@yuzisun
Copy link
Member

yuzisun commented May 1, 2024

There is already a cherry-pick workflow: https://github.com/kserve/kserve/blob/master/.github/workflows/cherry-pick.yml I see it as outdated. Maybe, we should replace/update that one instead of creating a new file?

This one does work not well, we can delete it

@spolti
Copy link
Contributor

spolti commented May 1, 2024

@andyi2it Can you help add the instruction for how to cherry pick the commits to the release doc ?

Maybe a small note in the [CONTRIBUTING.md](https://github.com/kserve/kserve/blob/master/CONTRIBUTING.md) as well

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
@yuzisun
Copy link
Member

yuzisun commented May 3, 2024

/lgtm
/approve

Copy link

oss-prow-bot bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyi2it, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oss-prow-bot oss-prow-bot bot added the approved label May 3, 2024
@yuzisun yuzisun merged commit a3fda9c into kserve:master May 4, 2024
43 of 44 checks passed
asd981256 pushed a commit to asd981256/kserve that referenced this pull request May 14, 2024
* workflow file for cherry-pick on comment

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* updated release notes and workflow

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Remove obsolete cherry pick workflow

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

---------

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Signed-off-by: asd981256 <asd981256@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a provision in KServe repo to allow cherry pick of PRs to release branches
5 participants