-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assign device to input tensors in huggingface server with huggingface backend #3657
Assign device to input tensors in huggingface server with huggingface backend #3657
Conversation
Signed-off-by: sailgpu <sailesh.duddupudi@nutanix.com>
0254104
to
52bf0d2
Compare
/lgtm |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cmaddalozzo, saileshd1402, sivanantha321, terrytangyuan, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… backend (kserve#3657) * Assign device of input tensors Signed-off-by: sailgpu <sailesh.duddupudi@nutanix.com> * lint fix Signed-off-by: sailgpu <sailesh.duddupudi@nutanix.com> --------- Signed-off-by: sailgpu <sailesh.duddupudi@nutanix.com> Signed-off-by: asd981256 <asd981256@gmail.com>
What this PR does / why we need it:
Currently, when we run huggingface server with a GPU, the input torch tensors are being stored in CPU instead of GPU, which is causing the following error:
To fix this, we can use the ".to()" function in the torch library to assign the input tensors to the correct device
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Special notes for your reviewer:
Checklist:
Release note:
Re-running failed tests
/rerun-all
- rerun all failed workflows./rerun-workflow <workflow name>
- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.