Refactor the ModelServer to let uvicorn handle multiple workers #3757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sivanantha321 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sivanantha321
changed the title
sivanantha321
commented
Jun 26, 2024
| app.add_middleware( | ||
| TimingMiddleware, | ||
| client=PrintTimings(), | ||
| metric_namer=StarletteScopeToName(prefix="kserve.io", starlette_app=app), | ||
| ) | ||
| self.cfg = uvicorn.Config( | ||
| app=app, | ||
| app="kserve.model_server:app", |
There was a problem hiding this comment.
This import string style is required for using --workers and --reload options. https://www.uvicorn.org/deployment/#running-programmatically
- Refactored the ModelServer to let uvicorn handle multiple workers. This will remove the bottleneck of using 'fork' for multiprocessing - Make FastAPI app instance easily accessible across the project so that users can easily add middlewares and custom exception handlers for custom models. - Use uvloop eventpolicy Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
sivanantha321
force-pushed
the
refactor-multiprocessing-modelserver
branch
from
be0f628
to
53dd335
Compare
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
sivanantha321
force-pushed
the
refactor-multiprocessing-modelserver
branch
from
e50015e
to
6f04620
Compare
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
sivanantha321
force-pushed
the
refactor-multiprocessing-modelserver
branch
from
d4510e2
to
00fdc0d
Compare
yuzisun
reviewed
Jul 20, 2024
| This can be called by a custom exception handler that wants to defer to the default handler behavior. | ||
| """ | ||
| # gracefully shutdown the server | ||
| loop.run_until_complete(self.stop()) |
There was a problem hiding this comment.
Do we still need to shut down the server?
yuzisun
reviewed
Jul 20, 2024
Comment on lines
+349
to
+354
| if "future" in context: | ||
| future = context["future"] | ||
| if future.done(): | ||
| future_exception = future.exception() | ||
| if future_exception: | ||
| logger.error(f"Future exception: {future_exception}") |
There was a problem hiding this comment.
what's the difference between exception and future_exception?
yuzisun
reviewed
Jul 20, 2024
|
|
||
| @pytest.fixture(scope="class") | ||
| def app(self, server): # pylint: disable=no-self-use | ||
| mp = pytest.MonkeyPatch() |
yuzisun
reviewed
Jul 20, 2024
Comment on lines
+46
to
+48
| await server.model_repository_extension.unload("TestModel") | ||
| await server.model_repository_extension.unload("NotReadyModel") | ||
| kserve_app.routes.clear() |
There was a problem hiding this comment.
These are executed after app is terminated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Refactored the ModelServer to let uvicorn handle multiple workers. This will remove the bottleneck of using 'fork' for multiprocessing
Make FastAPI app instance easily accessible across the project so that users can easily add middlewares and custom exception handlers for custom models.
Use uvloop eventpolicyWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note:
Re-running failed tests
/rerun-all- rerun all failed workflows./rerun-workflow <workflow name>- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.