Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to Go 1.20, kserve v0.11.2 #470

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

ckadner
Copy link
Member

@ckadner ckadner commented Jan 5, 2024

Motivation

Trying to prepare for the v0.12 release, but stuck sticking with kserve v0.11.2 for the time being since kserve v0.12.0-rc0 requires Go 1.21 which requires much more extensive changes (i.e. no available UBI image for Go 1.21, ...)

Modifications

Updated versions:

  • Go: 1.19 -> 1.20
  • UBI: 8.7 -> 8.9
  • OCP: 4.9 -> 4.12
  • kserve: v0.11.1 -> v0.11.2
  • K8s: 1.23 -> 1.26

Result

TBD

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner ckadner requested a review from rafvasq January 5, 2024 17:51
@rafvasq rafvasq linked an issue Jan 8, 2024 that may be closed by this pull request
Copy link
Member

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Christian, think this is fine even as a step towards 1.21 while we figure out more details about the UBI image for it.

Copy link

oss-prow-bot bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, rafvasq, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
Copy link

oss-prow-bot bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, rafvasq, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spolti
Copy link
Contributor

spolti commented Jan 9, 2024

Thanks Christian, think this is fine even as a step towards 1.21 while we figure out more details about the UBI image for it.

For cases where we don't yet have a UBI image for it, we probably can use the minimal/micro and install go manually.

@ckadner ckadner merged commit fc40dee into kserve:main Jan 9, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Go to supported version (1.20)
3 participants