Make the builder configurable in the Makefile #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckadner
force-pushed
the
odh-issues19
branch
from
e77334e
to
70ac1e0
Compare
spolti
commented
Nov 30, 2023
ckadner
reviewed
Nov 30, 2023
chore: Some developers might not have docker installed anymore. Thus it would be easier to have it configurable instead to do changes locally to build using, i.e, `podman` or `buildah`. It can be called by `make ENGINE=podman build` Signed-off-by: Spolti <fspolti@redhat.com>
ckadner
requested changes
Jan 10, 2024
Co-authored-by: Christian Kadner <ckadner@us.ibm.com> Signed-off-by: Filippe Spolti <filippespolti@gmail.com>
Co-authored-by: Christian Kadner <ckadner@us.ibm.com> Signed-off-by: Filippe Spolti <filippespolti@gmail.com>
|
@ckadner updated. thanks for the suggestions |
|
Thanks @spolti -- your changes work well. Just curious if you got this linter warning as well? Which does not show up in the CI logs. Appears unrelated to your changes, though. |
|
/approve |
|
The /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: ckadner, spolti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @ckadner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: Some developers might not have docker installed anymore.
Thus it would be easier to have it configurable instead
to do changes locally to build using, i.e,
podmanorbuildah.It can be called by
make ENGINE=podman build