Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add amdserver #179

Merged
merged 7 commits into from Nov 12, 2022
Merged

Add amdserver #179

merged 7 commits into from Nov 12, 2022

Conversation

varunsh-xilinx
Copy link
Contributor

This adds documentation for the AMD Inference Server: #2149

Proposed Changes

  • Adds an example guiding users to build an image and running an example
  • Adds YAML files and input data for examples

Since we don't have a distributable image right now, I haven't modified servingruntimes.md or serving_runtime.md because using one of the KServe runtimes requires a predefined image in the clusterservingruntimes definition.

@varunsh-xilinx
Add amdserver documentation
9ed811d 
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
@varunsh-xilinx
Update amdserver example
89aab32 
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
@varunsh-xilinx
Update README
5abcc61 
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
@netlify
Copy link

netlify bot commented Aug 17, 2022 •
edited

✅ Deploy Preview for elastic-nobel-0aef7a ready!

Name Link
🔨 Latest commit e1dfcad
🔍 Latest deploy log https://app.netlify.com/sites/elastic-nobel-0aef7a/deploys/636ee4bb64e5d200083e4ed8
😎 Deploy Preview https://deploy-preview-179--elastic-nobel-0aef7a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@varunsh-xilinx
Copy link
Contributor Author

@yuzisun what do you think?

yuzisun
yuzisun reviewed Oct 13, 2022
View reviewed changes
docs/modelserving/v1beta1/amd/README.md Outdated Show resolved Hide resolved
docs/modelserving/v1beta1/amd/README.md Outdated Show resolved Hide resolved
docs/modelserving/v1beta1/amd/README.md Outdated Show resolved Hide resolved
yuzisun
yuzisun reviewed Oct 13, 2022
View reviewed changes
docs/modelserving/v1beta1/amd/README.md Outdated Show resolved Hide resolved
docs/modelserving/v1beta1/amd/README.md Outdated Show resolved Hide resolved
@varunsh-xilinx
Merge branch 'main' into add-amdserver
3cfb140
@varunsh-xilinx
Update README
8d0500c 
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
@yuzisun
Copy link
Member

yuzisun commented Nov 5, 2022

@varunsh-xilinx Is this good to review again now?

@varunsh-xilinx
Copy link
Contributor Author

@yuzisun I'm currently working on documentation for adding a new serving runtime as we discussed earlier. Testing with ModelMesh will take some time so I'm thinking I'll remove the multi-model example for now and focus on the single model case. I'm hoping it'll be ready to review this week

@varunsh-xilinx
Remove multi-model example
f0b5195 
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
@varunsh-xilinx
Copy link
Contributor Author

@yuzisun this is ready to review again, thanks

@yuzisun
Copy link
Member

yuzisun commented Nov 12, 2022

Looks great! Thanks @varunsh-xilinx !

/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: varunsh-xilinx, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kserve-oss-bot kserve-oss-bot merged commit cbb364f into kserve:main Nov 12, 2022
@varunsh-xilinx varunsh-xilinx deleted the add-amdserver branch November 12, 2022 01:37
@varunsh-xilinx
Copy link
Contributor Author

Thank you for your help @yuzisun!

rachitchauhan43 pushed a commit to rachitchauhan43/website that referenced this pull request Nov 21, 2022
@varunsh-xilinx @yuzisun @rachitchauhan43
Add amdserver (kserve#179)
29c74c5 
* Add amdserver documentation

Signed-off-by: Varun Sharma <varun.sharma@amd.com>

* Update amdserver example

Signed-off-by: Varun Sharma <varun.sharma@amd.com>

* Update README

Signed-off-by: Varun Sharma <varun.sharma@amd.com>

* Update README

Signed-off-by: Varun Sharma <varun.sharma@amd.com>

* Remove multi-model example

Signed-off-by: Varun Sharma <varun.sharma@amd.com>

* Update README.md

Signed-off-by: Varun Sharma <varun.sharma@amd.com>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: rachitchauhan43 <rachitchauhan43@gmail.com>
alexagriffith pushed a commit to alexagriffith/website that referenced this pull request Jan 18, 2023
@varunsh-xilinx @yuzisun @alexagriffith
Add amdserver (kserve#179)
96002fd 
* Add amdserver documentation

Signed-off-by: Varun Sharma <varun.sharma@amd.com>

* Update amdserver example

Signed-off-by: Varun Sharma <varun.sharma@amd.com>

* Update README

Signed-off-by: Varun Sharma <varun.sharma@amd.com>

* Update README

Signed-off-by: Varun Sharma <varun.sharma@amd.com>

* Remove multi-model example

Signed-off-by: Varun Sharma <varun.sharma@amd.com>

* Update README.md

Signed-off-by: Varun Sharma <varun.sharma@amd.com>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: agriffith50 <agriffith50@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzisun yuzisun yuzisun left review comments

@theofpa theofpa Awaiting requested review from theofpa

Assignees

@yuzisun yuzisun

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@varunsh-xilinx @yuzisun @kserve-oss-bot