Add serving runtime logger configuration docs #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for elastic-nobel-0aef7a ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
9 tasks
spolti
approved these changes
May 7, 2024
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
sivanantha321
force-pushed
the
add-logger-docs
branch
from
7dd7611
to
b1dbd3e
Compare
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
yuzisun
reviewed
Jun 24, 2024
| }, | ||
| } | ||
| if args.configure_logging: | ||
| logging.configure_logging(args.log_config_file) |
There was a problem hiding this comment.
@sivanantha321 here should be logging.configure_logging(dictConfig) instead ?
yuzisun
reviewed
Jun 24, 2024
yuzisun
reviewed
Jun 24, 2024
yuzisun
reviewed
Jun 24, 2024
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sivanantha321, spolti, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Fixes #issue-number" or "Add description of the problem this PR solves"
Documents the proper way to configuring logger for kserve.
kserve/kserve#3577
Proposed Changes