bug-733 : fix src/lib/libast/tm/tmxdate.c #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While normalising the 'f' variable usage into tmxdate() the TM_ORDINAL case was overlooked.
McDutchie
pushed a commit
that referenced
this pull request
Mar 30, 2024
Reproducers:
$ printf '%(%F)T\n' '4th tuesday in march 2016'
2016-04-09
$ printf '%(%F)T\n' '4nd tuesday in march 2016'
2016-03-08
Expected, in both cases: 2016-03-22
It was a left over, while I reworked these things some time ago, I
normalised the 'f' variable usage (specially the +1 -1 usage), and
the cryptic TM_ORDINAL case was kinda magical and I left it
untouched.
Now thanx @stephane-chazelas, I got a test case and can understand
it. I added a test case to catch any regression in this area if one
try to make printf better :-)
src/lib/libast/tm/tmxdate.c:
- tmxdate(): While normalising the 'f' variable usage into
tmxdate(), also handle the TM_ORDINAL case, which had been
overlooked.
Thanks to @stephane-chazelas for the bug report.
Resolves: #733
McDutchie
pushed a commit
that referenced
this pull request
Mar 30, 2024
Reproducers:
$ printf '%(%F)T\n' '4th tuesday in march 2016'
2016-04-09
$ printf '%(%F)T\n' '4nd tuesday in march 2016'
2016-03-08
Expected, in both cases: 2016-03-22
It was a left over, while I reworked these things some time ago, I
normalised the 'f' variable usage (specially the +1 -1 usage), and
the cryptic TM_ORDINAL case was kinda magical and I left it
untouched.
Now thanx @stephane-chazelas, I got a test case and can understand
it. I added a test case to catch any regression in this area if one
try to make printf better :-)
src/lib/libast/tm/tmxdate.c:
- tmxdate(): While normalising the 'f' variable usage into
tmxdate(), also handle the TM_ORDINAL case, which had been
overlooked.
Thanks to @stephane-chazelas for the bug report.
Resolves: #733
McDutchie
pushed a commit
that referenced
this pull request
Mar 30, 2024
Reproducers:
$ printf '%(%F)T\n' '4th tuesday in march 2016'
2016-04-09
$ printf '%(%F)T\n' '4nd tuesday in march 2016'
2016-03-08
Expected, in both cases: 2016-03-22
It was a left over, while I reworked these things some time ago, I
normalised the 'f' variable usage (specially the +1 -1 usage), and
the cryptic TM_ORDINAL case was kinda magical and I left it
untouched.
Now thanx @stephane-chazelas, I got a test case and can understand
it. I added a test case to catch any regression in this area if one
try to make printf better :-)
src/lib/libast/tm/tmxdate.c:
- tmxdate(): While normalising the 'f' variable usage into
tmxdate(), also handle the TM_ORDINAL case, which had been
overlooked.
Thanks to @stephane-chazelas for the bug report.
Resolves: #733
McDutchie
pushed a commit
that referenced
this pull request
Mar 30, 2024
Reproducers:
$ printf '%(%F)T\n' '4th tuesday in march 2016'
2016-04-09
$ printf '%(%F)T\n' '4nd tuesday in march 2016'
2016-03-08
Expected, in both cases: 2016-03-22
It was a left over, while I reworked these things some time ago, I
normalised the 'f' variable usage (specially the +1 -1 usage), and
the cryptic TM_ORDINAL case was kinda magical and I left it
untouched.
Now thanx @stephane-chazelas, I got a test case and can understand
it. I added a test case to catch any regression in this area if one
try to make printf better :-)
src/lib/libast/tm/tmxdate.c:
- tmxdate(): While normalising the 'f' variable usage into
tmxdate(), also handle the TM_ORDINAL case, which had been
overlooked.
Thanks to @stephane-chazelas for the bug report.
Resolves: #733
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While normalising the 'f' variable usage into tmxdate() the TM_ORDINAL case was overlooked.