Skip to content

Patch Upstream Report: OpenSUSE

Jump to bottom Edit New page
Johnothan King edited this page Apr 8, 2023 · 15 revisions

The following OpenSUSE patches have now been upstreamed:

The following have NOT been upstreamed, because:

  • astksh_builtin_poll20120806_001.diff
    I'm unsure if users require this, and there are some regression test
    failures when building this on macOS [TODO: test other OSs].
    TODO: make an updated version of this patch so OpenSUSE can keep it.

  • ksh93-gmt2utc.dif
    This patch is not quite correct. See: 8d8a8257
    To get ksh to prefer UTC over GMT in 'printf %T' output, only the
    change in format[] was needed. The corresponding change in zone[]
    made it prefer UTC for London time, even in summer time, which is
    wrong -- e.g.:

      $ LANG=C TZ=Europe/London arch/*/bin/ksh -c 'date; printf %T\\n now'    
      Tue Jun 30 01:39:09 BST 2020    
      Tue Jun 30 00:39:09 UTC 2020

  • ksh-qemu.patch
    Your .spec applies this patch conditionally so it should not be upstreamed.
    Note that the race condition with vfork() or posix_spawn() is fixed by using
    fork() if job control is enabled.
    see: https://github.com/ksh93/ksh/commit/f207cd57
    discussion: https://github.com/ksh93/ksh/issues/79

  • ksh93-alias-k.dif
    In fact this was not upstreamed in 93v- as claimed. It's also wrong: alias
    and hash should not be declaration builtins as they do not modify variables.
    Please show me the contents of the non-public bug [bnc#824187] so I can
    verify if a fix is still needed.

  • ksh93-backtick.dif
    Not applicable; command substitutions have been fixed by smaller Red Hat
    patches and it is working well now. Please verify against your reproducers
    from [bnc#887320] [bnc#926172] [bnc#934437] [bnc#953533] [bnc#955221]
    (would be nice if I could see those bugs, too)

  • ksh93-cdpwd.dif
    Already fixed in bb4745e8 using a patch from Solaris.

  • ksh93-disable-vfork.dif - description: "disable vfork, use fork instead"
    Your .spec applies this patch conditionally so it should not be upstreamed.
    Note that the race condition with vfork() or posix_spawn() is fixed by using
    fork() if job control is enabled.
    see: https://github.com/ksh93/ksh/commit/f207cd57
    discussion: https://github.com/ksh93/ksh/issues/79

  • ksh93-fdstatus.dif
    Causes various regression test failures and hangs. Do not apply. The
    associated problems have likely been fixed already, e.g. ‘read’ can read
    from fifos just fine even without a final newline due to fixes in libast
    sfpkrd(). Please show me the contents of the relevant non-public bugs
    [bnc#808449, bnc#814135] so I can verify whether there is anything there
    left to fix.

  • ksh93-fs3d.dif
    Not applicable as both 3dfs and libcoshell have been removed from ksh 93u+m.

  • ksh93-int16double.dif
    Very similar patch applied in 5135cf65 with an additional fix for nvdisc.c.

  • ksh-locale.patch
    No-op change.

  • ksh93-jpold.dif
    This is already part of a Red Hat patch that was applied in ce68e1be.

  • ksh93-limits.dif
    This patch breaks the build on Alpine Linux with the musl C library. The build error is as follows:

+ cc -D_BLD_DLL -fPIC -D_BLD_ast '-D_AST_git_commit="9ddb45b1"' -Os -I. -I/usr/local/src/ksh/src/lib/libast -Icomp -I/usr/local/src/ksh/src/lib/libast/comp -Iport -I/usr/local/src/ksh/src/lib/libast/port -Isfio -I/usr/local/src/ksh/src/lib/libast/sfio -Istdio -I/usr/local/src/ksh/src/lib/libast/stdio -Iinclude -I/usr/local/src/ksh/src/lib/libast/include -Istd -I/usr/local/src/ksh/src/lib/libast/std -I/usr/local/src/ksh/arch/linux.i386-64/include -D_PACKAGE_ast -c /usr/local/src/ksh/src/lib/libast/stdio/vfwscanf.c
/usr/local/src/ksh/src/lib/libast/stdio/vfwscanf.c: In function '_ast_vfwscanf':
/usr/local/src/ksh/src/lib/libast/stdio/vfwscanf.c:102:40: error: 'OPEN_MAX' undeclared (first use in this function); did you mean 'FOPEN_MAX'?
  102 |   if (t = sfnew(NiL, buf, sizeof(buf), OPEN_MAX+1, SF_READ))
      |                                        ^~~~~~~~
      |                                        FOPEN_MAX
/usr/local/src/ksh/src/lib/libast/stdio/vfwscanf.c:102:40: note: each undeclared identifier is reported only once for each function it appears in
mamake [lib/libast]: *** exit code 1 making vfwscanf.o
mamake: *** exit code 1 making lib/libast
mamake: *** exit code 1 making all
package: make done  at Wed Feb  3 22:52:33 CET 2021 in /usr/local/src/ksh/arch/linux.i386-64
Add a custom footer
Add a custom sidebar
Clone this wiki locally