feat(tabs): pass the selected tab index to onDeselect #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ksieburg, I'm ok with this, but it will need a documentation update as well. |
|
Whoops. this is in your own repo...you might consider contributing this enhancement to our project. |
|
Omg. It's Tuesday and clearly my brain is not firing on all cylinders. I see your other PR. |
ksieburg
force-pushed
the
feat-tabs/addSelectedIndexToDeselect
branch
from
1fca691
to
ef58dd3
Compare
- Add the index of the tab the user attempted to open to the onDeselect call, which allows the user to directed to the selected tab after some work is performed. - Closes angular-ui#5820
ksieburg
force-pushed
the
feat-tabs/addSelectedIndexToDeselect
branch
from
ef58dd3
to
8a3a833
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after some work is performed.