Use true install time #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of assuming just installed, get the install date/time from the PackageManager. This makes the app ask for rating to old users as soon as they launch.
Covers the case of the app being reentered while the rate dialog is already present, which would cause a new instance to appear on top of the former (as long as the condition for showing was still met).
Store the date the user asked to be reminded later because using solely the true install time makes the criteria be met again at the next opportunity
Avoid stacking of multiple rate dialogs
|
@RandomShaper Looks good to merge. |
Instead of assuming just installed, get the install date/time from the PackageManager. This makes the app ask for rating to old users as soon as they launch.
Store the date the user asked to be reminded later because using solely the true install time makes the criteria be met again at the next opportunity
|
I'm still too new and clumsy with Git. I've messed it up a bit, but I think it's still OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of assuming just installed, get the install date/time from the PackageManager.
This makes the app ask for rating to old users as soon as they launch.