Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add British English. #57

Closed
kslazarev opened this issue Mar 25, 2013 · 1 comment
Closed

Add British English. #57

kslazarev opened this issue Mar 25, 2013 · 1 comment
Assignees
Milestone

Comments

@kslazarev
Copy link
Owner

No description provided.

@ghost ghost assigned eLod Apr 8, 2013
eLod added a commit that referenced this issue Apr 8, 2013
@eLod
Copy link
Collaborator

eLod commented Apr 8, 2013

@kslazarev could you please review my commits if they seem ok to you wrt to the module naming convention we've talked about (they're on the feature/en-GB branch)

my only problem was with getting the union back, e.g. 0.42 is 'zero and forty-two hundredth' for english, and if you specify :without_zero => true then it becomes 'forty-two hundredth'; however with en-GB 0.42 the translation should be 'point four two', so though zero is not displayed the union string ('point') is.

i ended up placing :integral => integral_part.to_i into the fractional configuration (in float wrapper), so i know in the fractional part that the integral part is zero. not sure if this is the best approach though.

kslazarev added a commit that referenced this issue Apr 14, 2013
…ited from En. Use DRY principle to generate british fractional part. Set option 'remove_zero: false' by default for british (more convenient way).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants