Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 4 added 'other' for certain languages #104

Merged
merged 2 commits into from Nov 27, 2014
Merged

Rails 4 added 'other' for certain languages #104

merged 2 commits into from Nov 27, 2014

Conversation

Igosuki
Copy link
Contributor

@Igosuki Igosuki commented Nov 27, 2014

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) when pulling 2640fcf on nexkap:master into 8664645 on kslazarev:master.

miks added a commit that referenced this pull request Nov 27, 2014
Rails 4 added 'other' for certain languages
@miks miks merged commit 2a6b341 into kslazarev:master Nov 27, 2014
@dblock
Copy link
Collaborator

dblock commented Nov 27, 2014

Why is this only on thousands though?

@dblock
Copy link
Collaborator

dblock commented Nov 27, 2014

It also needs a CHANGELOG entry and a test.

@Igosuki
Copy link
Contributor Author

Igosuki commented Dec 1, 2014

I agree. And that's because it's only for languages using an invariant for certain words.
For instance, in French 'mille' is the only quantity that does not take an s when pluralized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants