Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add German language #52

Closed
wants to merge 2 commits into from
Closed

Add German language #52

wants to merge 2 commits into from

Conversation

GSI
Copy link

@GSI GSI commented Mar 16, 2013

I translated the yml's to German. What is the purpose/meaning of the 'mega:' element in them?

Also, how are the tests supposed to be run?

kslazarev added a commit that referenced this pull request Mar 17, 2013
…ure/german

Conflicts:
	lib/numbers_and_words/strategies.rb
	lib/numbers_and_words/translations_helpers.rb
kslazarev added a commit that referenced this pull request Mar 17, 2013
…ure/german

Conflicts:
	lib/numbers_and_words/strategies.rb
	lib/numbers_and_words/translations_helpers.rb
@kslazarev
Copy link
Owner

What is the purpose/meaning of the 'mega:' element in them?

In general (:en) case, ':mega' field include capacity names: [..thousand, million, billion, trillion..].
In some languages (:ru), ':mega' elements is names of the fields in language yaml file. In that fields we have some language customizations depends on pluralization, for example.

Also, how are the tests supposed to be run?

It's quite simple, just add/translate 'integer/fixture_examples/de.yml' in spec directory, as you already have done. And that's all. 'rspec, rspec, rspec'. If you want to focus only on your language, replace line (numbers_and_words_spec.rb:7) by:

[:de].each do |locale| 

Updated: I merge all your commits in 'feature/german' branch. There are some changes in the project's architecture. Use that branch instead to continue development.

kslazarev added a commit that referenced this pull request May 14, 2013
@ghost ghost assigned kslazarev May 19, 2013
kslazarev added a commit that referenced this pull request May 19, 2013
@kslazarev kslazarev closed this May 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants