Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespaced NumbersAndWords #7

Merged
merged 1 commit into from
Mar 24, 2012
Merged

Conversation

dblock
Copy link
Collaborator

@dblock dblock commented Mar 24, 2012

There're quite a few things in the global namespace, who knows what they collide with :) Namespaced everything to NumbersAndWords.

Small note: there're a couple of places where namespace were declared as module Foo::Bar, which is actually different from

module Foo 
  module Bar
  end
end 

The first case requires the namespace to have already been declared elsewhere, which would break depending in which order the files are loaded.

@dblock
Copy link
Collaborator Author

dblock commented Mar 24, 2012

Btw, you can view the diff with w=1 which turns off showing differences in spaces and tabs and makes it a lot easier on the eyes: https://github.com/kslazarev/number_to_words_ru/pull/7/files?w=1

@kslazarev
Copy link
Owner

Wow, I didn't know about w=1. Thank you.

@kslazarev
Copy link
Owner

You'll right in both cases. :)
But I don't understand your double empty line at the end of each file.

@kslazarev
Copy link
Owner

Also for single line ruby block we should use '{}' , as more preferable approach, I think. We must use code space more rational. (but code line length should not be greater 90)

@kslazarev kslazarev merged commit aa26d0e into kslazarev:development Mar 24, 2012
@ghost ghost assigned dblock May 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants