Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ordinal support for dutch (nl) locale #90

Closed
wants to merge 5 commits into from

Conversation

kreintjes
Copy link

It is not perfect yet, but it is a start.

I did not know exactly how to fix these problems:
42nd = 'tweeenveertigste', but should be 'tweeënveertigste' (this goes wrong because 42 = 'tweeenveertig' is also wrong)
131st = 'honderdsteéénendertigste', but should be 'honderdéénendertigste'
133rd = 'honderdstedrieendertigste', but should be 'honderddrieëndertigste'
1000st = 'éénduizendste', but should be 'duizendste' (this goes wrong because 1000 = 'éénduizend' is also wrong)
4256th = 'vierduizend tweehonderdzesenvijftigste', but should be 'vierduizend tweehonderdzesenvijftigste'

For some correct examples (only in Dutch) see: http://woordenlijst.org/leidraad/6/9

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0%) when pulling c40f4cb on kreintjes:master into 6b681be on kslazarev:master.

@dblock
Copy link
Collaborator

dblock commented Nov 22, 2013

I recommend you write failing tests for all those other examples, someone can maybe jump in to help fix them.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0%) when pulling 7d054f7 on kreintjes:master into 6b681be on kslazarev:master.

@kreintjes
Copy link
Author

Added extra tests for the failing examples (including the currently wrong non ordinal numbers). If someone could fix these examples or point me into the direction to fix them, I (and other Dutch speaking people) would be glad.

@miks
Copy link
Collaborator

miks commented Dec 18, 2013

I can't fix tests because I don't know Dutch, for example:

       expected: "vierduizend tweehonderdzesenvijftigste"
                got: "vierduizend tweehonderdstezesenvijftigste" (using ==)

If you can provide language logic, at least I can try.

@kreintjes kreintjes closed this Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants