Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor in Text tool have too bad visibility #184

Closed
MurzNN opened this issue Dec 23, 2020 · 13 comments
Closed

Cursor in Text tool have too bad visibility #184

MurzNN opened this issue Dec 23, 2020 · 13 comments
Assignees
Labels
bug Something isn't working
Projects

Comments

@MurzNN
Copy link
Contributor

MurzNN commented Dec 23, 2020

Current cursor in Text tool have too bad visibility when typing text, for me it have white color with too muted shadow, so it's hard to see it when moving back using arrow keys. And sometimes it is not visible at all!
Can you make it more visible? Thanks!

@DamirPorobic
Copy link
Member

This is actually a Qt bug that I have reported in February of this year (2020) and still nothing from Qt side https://bugreports.qt.io/browse/QTBUG-82022

@DamirPorobic DamirPorobic added the bug Something isn't working label Dec 23, 2020
@DamirPorobic
Copy link
Member

A workaround seems to be to draw some background, which we're already doing in case you've noticed that the background gets a little bit whiter while writing text. We could try making it less transparent, that might improve the visibility.

@MurzNN
Copy link
Contributor Author

MurzNN commented Dec 23, 2020

Here is increased screenshot of current cursor:
image

@MurzNN
Copy link
Contributor Author

MurzNN commented Dec 23, 2020

A workaround seems to be to draw some background

Yes, this is a good workaround until Qt big will be fixed, if in edit mode the textbox will have a white non-transparent background.

@DamirPorobic DamirPorobic added this to To do in v0.4.1 via automation Dec 23, 2020
@DamirPorobic
Copy link
Member

@MurzNN can you just quickly try to disable the item shadow and check if the cursor is still hard to see?

@MurzNN
Copy link
Contributor Author

MurzNN commented Dec 24, 2020

Please describe how can I disable item shadow for texts? When I select "Effect = No Effect" in Text tool before adding text rectangle, text still added with shadow 🤔
When I try to select the text item after via Select tool, and change effect - the changes applied to image, instead of selected object (other changes like color, font size - applied to text item successfully).

@DamirPorobic
Copy link
Member

You can enable and disable shadow for items in the Settings (Settings > Annotator > Paint Item Shadow). But I'm quite positive that the shadow is causing this issue.

@DamirPorobic
Copy link
Member

I have lowered the alpha for the drawn background and I've added some functionality to not draw this background when shadow is disabled, I think that this could work for now until Qt fixes the real issue. You might check tonight for new version which includes those changes.

v0.4.1 automation moved this from To do to Done Dec 24, 2020
@MurzNN
Copy link
Contributor Author

MurzNN commented Dec 24, 2020

With disabled shadows - cursor becomes visible:
image
But it have too large width, I think that 1px width will be enough.

@MurzNN
Copy link
Contributor Author

MurzNN commented Dec 24, 2020

Also it's little confusing, that cursor isn't shows immediately when entering into edit mode, but starts blinking after timeout, also sometimes hides after moving left-right via arrow keys. Maybe you can find quick fix for this too?

@DamirPorobic
Copy link
Member

The thickness is caused by some logic that prevents blurry drawing for odd width, I might loon into that later on but at the moment it's low prio and not as simple to fix.

I have changed it not to be visible right away and reduced the tick interval from 1000ms to 800ms.

@MurzNN
Copy link
Contributor Author

MurzNN commented Dec 25, 2020

You might check tonight for new version which includes those changes.

That's strange, that last continuous build miss .deb and other regular builds:
image

But in Travis logs there is successful build, at least, for deb: https://travis-ci.org/github/ksnip/ksnip/builds/751383907

@MurzNN
Copy link
Contributor Author

MurzNN commented Dec 28, 2020

You might check tonight for new version which includes those changes.

I checked, now works much better - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

2 participants